CommentFileSizeAuthor
#8 2759193-8.patch13.03 KBchandan chaudhary
#5 2759193-3.patch13.03 KBrajeshwari10
#2 2759193-2.patch13.03 KBrajeshwari10

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 commented
Status: Active » Needs review
StatusFileSize
new 2759193-2.patch13.03 KB

replaced deprecated cal to Drupal::url .

Status: Needs review » Needs work

The last submitted patch, 2: 2759193-2.patch, failed testing.

The last submitted patch, 2: 2759193-2.patch, failed testing.

rajeshwari10’s picture

rajeshwari10 commented
Status: Needs work » Needs review
StatusFileSize
new 2759193-3.patch13.03 KB

Done changes where the test bot have failed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Thanks, just a small coding standard fix needed.

+++ b/src/Tests/TokenCurrentPageTest.php
@@ -2,6 +2,7 @@
 
+use Drupal\Core\Url;
 /**

should have an empty line between the use and the comment.

chandan chaudhary’s picture

chandan chaudhary commented
Title: Replace all calls to the deprecated Drupal::url() from the code base. » Replace all calls of the deprecated Drupal::url() from the code base.
chandan chaudhary’s picture

chandan chaudhary commented
Status: Needs work » Needs review
StatusFileSize
new 2759193-8.patch13.03 KB

Added the empty line

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed and pushed.

  • Berdir committed 39941ec on 8.x-1.x authored by rajeshwari10 
    Issue #2759193 by rajeshwari10, Chandan Chaudhary: Replace all calls of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshwari10’s picture

rajeshwari10 commented
Assigned: rajeshwari10 » Unassigned