Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
45 problems (45 errors, 0 warnings)
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | token-eslint-error-2682289-7.patch | 256 bytes | hussainweb |
| #2 | token-eslint-error-2682289-2.patch | 8.35 KB | neelanjana das |
Comments
Comment #2
neelanjana das commentedThis patch removes all the errors.
Comment #3
neelanjana das commentedComment #4
neelanjana das commentedComment #5
berdirjquery.treeTable.js sounds like an external library. I don't think we should change that at all.
We use 2.3.0, the latest version on http://plugins.jquery.com/treetable is 3.2.0. We should ensure that is correctly formatted. and consider using that.
Comment #6
hussainwebOpened #2737889: Upgrade to latest jquery treetable
Comment #7
hussainwebAfter removing the treetable changes, this is all that is left. I guess we could restructure the vendor files like core does to make it clear that this is not our code. Anyway, like @Berdir says, upgrading to 3.2.0 might fix most of the errors (and I see other fixes since 3.2.0 release as well). We are dealing with that in another issue anyway: #2737889: Upgrade to latest jquery treetable
Comment #9
berdirYeah, looks like that's all now. committed.