Problem/Motivation

We moved token information functions to a service in #2640612: Move token information functions to a service. We didn't remove the functions in that issue to check for more effects. Let's do that in this follow-up.

Proposed resolution

Remove functions:

  1. token_get_info
  2. token_get_global_token_types
  3. token_get_invalid_tokens_by_context
  4. token_get_invalid_tokens

Remaining tasks

Patch, Review and Commit

User interface changes

None

API changes

The deprecated functions may not be used anymore. Callers should directly use the @token service.

Data model changes

None

CommentFileSizeAuthor
#8 remove_deprecated_token_info-2641132-8.patch6.48 KBhussainweb
#8 interdiff-7-8.txt1.98 KBhussainweb
#7 remove_deprecated_token_info-2641132-7.patch4.97 KBhussainweb
#7 interdiff-5-7.txt1.24 KBhussainweb
#5 remove_deprecated_token_info-2641132-5.patch3.73 KBhussainweb
#5 interdiff-2-5.txt1.32 KBhussainweb
#2 remove_deprecated_token_info-2641132-2.patch2.58 KBhussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new remove_deprecated_token_info-2641132-2.patch2.58 KB

Here is a patch which should work when we are ready.

Status: Needs review » Needs work

The last submitted patch, 2: remove_deprecated_token_info-2641132-2.patch, failed testing.

The last submitted patch, 2: remove_deprecated_token_info-2641132-2.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-5.txt1.32 KB
new remove_deprecated_token_info-2641132-5.patch3.73 KB

Fixing...

Status: Needs review » Needs work

The last submitted patch, 5: remove_deprecated_token_info-2641132-5.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-5-7.txt1.24 KB
new remove_deprecated_token_info-2641132-7.patch4.97 KB
hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new interdiff-7-8.txt1.98 KB
new remove_deprecated_token_info-2641132-8.patch6.48 KB

Removing some more usages...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Nice. #7 didn't fail but we have an existing issue to add some test coverage for the token browser UI, so that's OK.

I only found a single usage of all those functions in any of my contrib projects and that's privatemsg, which is not ported yet. Meaning, this should be good to go.

  • Berdir committed 363ca32 on 8.x-1.x authored by hussainweb 
    Issue #2641132 by hussainweb: Remove @deprecated token information...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.