I was reading the API.txt docs and the API docs in the code to understand token module better, and decided to submit a code style cleanup patch for token module. I found lots of comment code style problems, which I fix in this patch as well as one concatenation code style patch (given that this is Drupal 6 code).

- phpdoc should start with one line summaries
- @param should use $variable_name with dollar
- indentation issues
- some smaller stuff

Patch made out of the SVN repo I am using.

CommentFileSizeAuthor
#2 token-coder_warnings.patch5.16 KBmustafau
token-code-cleanup.patch10.79 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Since this has lots of changes, and IMHO moves to a quite positive direction, it would be great to move this on. Any reviews?

mustafau’s picture

mustafau commented
Version: 6.x-1.10 » 6.x-1.x-dev
Status: Needs review » Needs work
StatusFileSize
new token-coder_warnings.patch5.16 KB

Looks great however it does not apply anymore.

Attached patch eliminates coder.module warnings for Token. I will merge my patch with yours after you update it to apply to latest -6--1 branch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Closed (duplicate)

Well, technically this is newer than #241288: Coding Standards and they both have patches so I'm marking this a duplicate...your help there would be appreciated. I would also like to get this fixed and will make it the priority patch for token (i.e. nothing else gets fixed until this one).