Tokens with a < or > in the key (for example "list<$token_type>") breaks the js ui. Adding replacements '<' => '-' and '>' => '-' solves this.

CommentFileSizeAuthor
#1 token-characters_break_js_ui-1557766-1.patch644 bytesauth
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

auth’s picture

auth CreditAttribution: auth commented
FileSize
token-characters_break_js_ui-1557766-1.patch644 bytes

Attaching patch

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Active » Needs review

Marking as 'needs review'.

Status: Needs review » Needs work

The last submitted patch, token-characters_break_js_ui-1557766-1.patch, failed testing.

nyleve101’s picture

nyleve101 CreditAttribution: nyleve101 commented

Hi Auth,

I'm also experiencing this issue, which your patch solves for me, will you be updating your patch?

Hope you're well!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review

#1: token-characters_break_js_ui-1557766-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, token-characters_break_js_ui-1557766-1.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review

#1: token-characters_break_js_ui-1557766-1.patch queued for re-testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Thanks, committed to 7.x-1.x now that I fixed the random test failure.
http://drupalcode.org/project/token.git/commit/02dfbd4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.