On update the hook_node_update in TOC attempts to delete the old record it has in the database and then insert the new. However the query includes the condition with the current VID which will be the current VID, not the old one. The result is that every node revision of a node with the Show TOC set will be included in the table forever. Patch to follow.

CommentFileSizeAuthor
#4 remove_revisions-2883497-4.patch772 bytesjoel_osc
#2 remove_revisions-2883497-2.patch300 bytesjoel_osc

Comments

joel_osc created an issue. See original summary.

joel_osc’s picture

joel_osc commented
Status: Active » Needs review
StatusFileSize
new remove_revisions-2883497-2.patch300 bytes
joel_osc’s picture

joel_osc commented
Status: Needs review » Active

After looking at this a bit further I think this needs a bit more work. I now think leaving the revisions is a good thing, so maybe at some point removing the deletion lines altogether is a 'clean-up' fix as they don't do anything good or bad today.

joel_osc’s picture

joel_osc commented
Status: Active » Needs review
StatusFileSize
new remove_revisions-2883497-4.patch772 bytes

I think the logic in this patch might work a bit better and work with workbench content moderation which provides the ability to have a draft version of a node (new vid) and a published version of a node (old vid) at the same time.