Problem/Motivation

Deepl throws error when using Pro version.

Steps to reproduce

Setup the Pro version,
Tried to import the Glossaries,
Batch started but and error occurred.

AssertionError: assert(is_string($glossary_id)) in assert() (line 119 of modules/contrib/tmgmt_deepl/modules/tmgmt_deepl_glossary/src/DeeplMultilingualGlossaryApiBatch.php).
Drupal\tmgmt_deepl_glossary\DeeplMultilingualGlossaryApiBatch::syncGlossariesFinishedCallback(1, Array, Array, '2 sec') (Line: 458)

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 tmgmt_deepl-3565603-add-validation.patch1.28 KBzubair_muhammad_zp

Issue fork tmgmt_deepl-3565603

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zubair_muhammad_zp created an issue. See original summary.

zubair_muhammad_zp’s picture

zubair_muhammad_zp commented
StatusFileSize
new tmgmt_deepl-3565603-add-validation.patch1.28 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.2.14 » 2.2.x-dev
Status: Active » Needs review
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Needs review » Needs work

@zubair_muhammad_zp Can you create a merge request with the fix please?
Thx.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Needs merge request

phily made their first commit to this issue’s fork.

phily opened merge request !66

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented
Status: Needs work » Needs review

MR!66 done from patch at comment #2

  • steffenr committed ecaedcba on 2.2.x authored by phily 
    fix: #3565603 Check for glossary ($glossary_id) before using it
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.