Thickbox for logins

I have tested it and it seems to work and the code looks nice.

A small problem was that Safari 2 and Firefox 2 didn't draw the box as they should. On Safari the windows poped up at the right size but aligned to the left. On Firefox the height was ok but the width was 100 % of the browser window.

<script>
window.onload = checkVisit;

function setCookie(name, value, expires, path, domain, secure) {
document.cookie= name + "=" + escape(value) +
((expires) ? "; expires=" + expires.toGMTString() : "") +
((path) ? "; path=" + path : "") +
((domain) ? "; domain=" + domain : "") +
((secure) ? "; secure" : "");
}

function getCookie(name) {
var dc = document.cookie;
var prefix = name + "=";
var begin = dc.indexOf("; " + prefix);
if (begin == -1) {
begin = dc.indexOf(prefix);
if (begin != 0) return null;
} else {
begin += 2;
}
var end = document.cookie.indexOf(";", begin);
if (end == -1) {
end = dc.length;
}
return unescape(dc.substring(begin + prefix.length, end));
}

function checkVisit() {
// Check last viewed version
var cookie = getCookie("javawin");
if (cookie == null || parseFloat(cookie) < 1.2) {

ShowThickbox();

date=new Date;
date.setMonth(date.getMonth()+3);
setCookie("javawin", "1.2", date);

}
}

function ShowThickbox()
{
TB_show('Thickbox Title', '/xampp/I-Create/?q=user/login?KeepThis=true&TB_iframe=true&height=400&width=600', null);
}
</script>

I haven't studied the patch but I would I have code to separate the /login? from the template.php with a page-login.tpl.php If we could work together I think this would be beneficial for all.
http://codylindley.com/thickboxforum/comments.php?DiscussionID=390&page=1#Item_0

Now it works very well in Safari and Firefox for me. Committed to HEAD, please try it out and report back here.

Thanks for working on the patch! All the cool functions in the Thickbox module is user contributed :-).

Link to HEAD http://drupal.org/node/96785

After I enabled for the login link from the admin configuration, the link to user/login still shows the Drupal login page instead of the Thickbox window.
I have a new install of the module. The admin->site configuration->Thickbox seems the only place I can configure the module. What am I missing?

Yes, I can confirm that I am using HEAD and I did set the admin/config to "enable for login link". When I point my browser to user/login (as anonymous user), I get the regular HTML login page.
I'd appreciate it if you can point me a direction of what I am missing.

Thank you for the clarification. I tried a login link generated by Drupal on a node. The Thickbox login did show up. I am happy with that. However, when I added the login link (user/login as the path) to a piece of text like this
Please <a href="user/login">login</a>
I got a blank Thickbox window after I logout and click the link. I can see the link is converted to /thickbox_login... but the input fields for usename/password don't show in the login window.
Anything I didn't do correctly here?
Thanks in advance.

You hit the nail right on the head. It is a problem with the path. I was testing the module with a sandbox site which is not based off the root directory. It worked when I moved the module to the root.
Now that we know what the issue is, I am not sure if the developers would consider it a problem to fix. So I will just close the issue until someone think the issue is something that needs to be fixed.

Thanks a lot.

Thanx i was also stuck in similar problem not it is resolved.