Closed (fixed)
Project:
ThemeKey
Version:
7.x-3.4
Component:
Documentation
Priority:
Minor
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2015 at 13:53 UTC
Updated:
19 Aug 2015 at 14:52 UTC
Jump to comment: Most recent
Comments
Comment #1
mkalkbrennerI don't have any knowledge about Islandora. But the implementation of function islandora_themekey_themekey_global() seems inefficient to me.
hook_themekey_global() is only meant for *really* simple properties, because they're populated on every page request.
But the somehow complex logic in your implementation should be moved to mapping functions which are only executed on demand.
Why is your module not mirrored on drupal.org?
Comment #2
mkalkbrennerRe-open this issue if https://github.com/mjordan/islandora_themekey/issues/6 is solved.