Hi,

A lot of other modules put their example module into "Example modules" package, Themekey's one is into "Development" package. Let's change that!

CommentFileSizeAuthor
#1 themekey-2046143-1-change_example_package.patch551 bytessimon georges

Comments

simon georges’s picture

simon georges commented
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new themekey-2046143-1-change_example_package.patch551 bytes

I removed useless "files[]" directives while I was at it (since there are no classes into the files).

This patch is part of the #1day1patch initiative.

izus’s picture

izus commented
Status: Needs review » Reviewed & tested by the community

Hi,
This looks great, Thanks
RTBTCings

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Reviewed & tested by the community » Needs review

you're right regarding the files. But can you point my to a documentation or spec where to put example modules for developers?

simon georges’s picture

simon georges commented

I don't think there is any documentation, I just have other example modules where this is the case:

I'm thinking for consistency, it would be best if all modules would follow this rule.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed

http://drupalcode.org/project/themekey.git/commit/1bcb199

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.