Closed (fixed)
Project:
ThemeKey
Version:
6.x-3.x-dev
Component:
Code / API
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
11 Jul 2011 at 21:59 UTC
Updated:
25 Aug 2011 at 07:52 UTC
Jump to comment: Most recent file
All the third party module integrations in ThemeKey's module folder might cause (fatal) errors if such a module gets dectivated.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1215656.d7.patch | 5.26 KB | mkalkbrenner |
| #4 | 1215656.module_name_fix.patch | 1.55 KB | mkalkbrenner |
| #1 | 1215656.d6.patch | 1.21 KB | mkalkbrenner |
Comments
Comment #1
mkalkbrennerpossible fix for ThemeKey 6 attached
Comment #2
chawl commentedPatch works perfectly, tx :)
Comment #3
mkalkbrennerThx for testing.
Now, we need something similar for D7.
Comment #4
mkalkbrennerI wonder why it worked @chawl because I discovered a serious bug regarding the module names while porting this to ThemeKey 7.
Attached is a patch against current 6.x-3.x branch in git.
Comment #5
mkalkbrennerComplete patch for ThemeKey 7.x-1.x
Comment #6
chawl commentedHmm, I hope I understand.
As I only tried disabling wurfl and "if" conditional always returned false because of path problem, themekey_scan_modules() was always invoked, thus variables table was always ok but I didn't recognise that no inc was really included as I was not using TK actively at test time whereat I had no rules defined :S
Sorry for casual testing.
Comment #7
mkalkbrenner@chawl: no problem. Current version in git should work like expected now.
Comment #8
mkalkbrenner