Problem/Motivation

Found code arrays that use the += operator to merge arrays - php does not allow this.

Proposed resolution

rewrite this to use array_merge. $x + = $y becomes $x = array_merge( $x, $y );

Remaining tasks

reviews needed, regression testing.

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#1 1243496.patch2.01 KBKevin Baluha

Comments

Kevin Baluha’s picture

Kevin Baluha commented
StatusFileSize
new 1243496.patch2.01 KB
Kevin Baluha’s picture

Kevin Baluha commented
Status: Active » Fixed
arcaneadam’s picture

arcaneadam commented

A couple things.

1. PHP does use the '+' as an array union operator. (http://php.net/manual/en/language.operators.array.php) So if this is causing your site to have 500 errors then there is probably an underlying issue elsewhere (possibly).

2. The 7.x version is still very much a development version at this point. Therefore it's going to be buggy and not ready for prime time.

3. Please read the Issue queue handbook(http://drupal.org/node/317) on how the issue queues work. I'm not a a jerk about it in my issue queue but I can guarantee that as you get more involved some other project maintainers will gripe at you if you are not filing issues correctly, or worse just flat out ignore the issue you are having because you didn't file it correctly.

I appreciate your desire to help with the project and as I said the 7.x version is not ready for production yet, so take it as it is, but I am working on it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.