Support latest version of Twilio library [#2997261]

Separate from #2833969: Document that there is no support for Twilio 5 PHP library:

The module currently doesn't support Twilio's 5.x version of their php sdk and only works with the 4.x version.

Since 4.x is deprecated and we don't know why (security? using legacy api features that will get dropped?) it would be good to upgrade the tfa_basic code to work with the 5.x version of Twilio's code.

This will require the minimum php version to be 5.5, which seems fine for anyone interested in security is likely already on that or newer anyway.

Comment	File	Size	Author
#16	twilio-v5-2997261-16.patch	5.55 KB	klausi
#16	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#15	interdiff.txt	3.24 KB	klausi
#15	twilio-v5-2997261-15.patch	5.11 KB	klausi
#15	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#13	twilio_php_api_update-2997261-13.patch	4.66 KB	jpsalter
#13
#12	twilio_php_api_update-2997261-12.patch	4.54 KB	jpsalter
#12
#11	twilio_php_api_update-2997261-11.patch	4.54 KB	jpsalter
#11
#9	twilio_php_api_update-2997261-9.patch	3.26 KB	jpsalter
#9	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#7	twilio_php_api_update-2997261-7.patch	3.31 KB	jpsalter
#7	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
#4	twilio_php_api_update-2997261-4.patch	3.31 KB	jpsalter
#4	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 September 2018 at 15:11

greggles created an issue. See original summary.

Comment #2

esolitos

he/him

Italian

Trondheim

CreditAttribution: esolitos as a volunteer and at Ramsalt Lab commented 12 November 2018 at 14:35

I might be able to step in to help as I'll need to use a PIN authentication for a project soon.

I'll be in touch with a patch hopefully soon.

Comment #3

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 12 November 2018 at 16:08

Good to hear, esolitos! Would be great to get this support working well with a modern version of the Twilio library.

Comment #4

jpsalter CreditAttribution: jpsalter commented 4 December 2018 at 22:26

File	Size
twilio_php_api_update-2997261-4.patch	3.31 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

This patch supports the latest version of the Twilio PHP library (5.26.0).
You can install the library via composer or direct download and it should work correctly.

Comment #5

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 5 December 2018 at 00:07

Status:

Active

» Needs review

Thanks so much for your work!

I noticed a few nitpick things:

+        // the number you'd like to send the message to

Comments should start with an upper case and be a sentence that ends with punctuation.

+    'version callback' => array('\Twilio\VersionInfo', "string"), // Calls Twilio version function via PHP array syntax

Same punctuation missing here and comments should be on a line on their own (no trailing comments).

These are very small issues so I'll leave it at needs review, but would be good to fix prior to commit.

Comment #6

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles at Morris Animal Foundation commented 5 December 2018 at 00:08

whoops and need to fix up my credit.

Comment #7

jpsalter CreditAttribution: jpsalter commented 5 December 2018 at 00:25

File	Size
twilio_php_api_update-2997261-7.patch	3.31 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

I've added punctuation to the comments. Thanks for the feedback.

Comment #8

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles at Morris Animal Foundation commented 5 December 2018 at 00:31

Thanks, jpsalter. I just noticed a few more things:

+  // Necessary to get the version information

Missing punctuation on that one.

+    'version callback' => array('\Twilio\VersionInfo', "string"), // Calls Twilio version function via PHP array syntax.

This comment should be moved to it's own line like below.

+    // Calls Twilio version function via PHP array syntax.
+    'version callback' => array('\Twilio\VersionInfo', "string"),

Or the comment could be removed.

I'm unlikely to be able to test this functionality - would be great if other folks could.

Comment #9

jpsalter CreditAttribution: jpsalter commented 5 December 2018 at 18:41

File	Size
twilio_php_api_update-2997261-9.patch	3.26 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

More comment cleanup.

Comment #10

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 6 December 2018 at 10:11

Status:

Needs review

» Needs work

2 files were hidden/shown/deleted

File	Size
twilio_php_api_update-2997261-4.patch	3.31 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
twilio_php_api_update-2997261-7.patch	3.31 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

there is still an old "@return Services_Twilio|FALSE" doc comment.

Please make sure to update all references to Services_Twilio.

Comment #11

jpsalter CreditAttribution: jpsalter commented 12 December 2018 at 00:02

File	Size
twilio_php_api_update-2997261-11.patch	4.54 KB

Updated the comments. Changed the catching of an exception too.

Comment #12

jpsalter CreditAttribution: jpsalter commented 12 December 2018 at 00:25

File	Size
twilio_php_api_update-2997261-12.patch	4.54 KB

Fixing logic for library load.

Comment #13

jpsalter CreditAttribution: jpsalter commented 12 December 2018 at 00:29

File	Size
twilio_php_api_update-2997261-13.patch	4.66 KB

Sorry - wrong diff before. This fixes the logic.

Comment #14

hoegrammer CreditAttribution: hoegrammer commented 2 February 2019 at 21:38

Hi, the patch in #13 nearly worked for me but I had to make a further change:

In tfa_basic.module I replaced
if (module_exists('libraries') && $library = libraries_load('twilio') && !empty($library['loaded'])) {
    $twilio_available = TRUE;
}

with

if (module_exists('libraries') && $library = libraries_load('twilio')) {
  if (!empty($library['loaded'])) {
    $twilio_available = TRUE;
  }
}

I'm puzzled as to why this made any difference, but without it I found that the Twilio fields (SID, etc) were missing from the setup form.

It's odd, because I don't see why that change should make any difference! (If anyone can shed light on this I'd be grateful). Thanks!

Comment #15

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi at jobiqo - job board technology commented 3 June 2019 at 15:42

Status:

Needs work

» Needs review

File	Size
twilio-v5-2997261-15.patch	5.11 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
interdiff.txt	3.24 KB

4 files were hidden/shown/deleted

File	Size
twilio_php_api_update-2997261-9.patch	3.26 KB
7.x-1.x: PHP 5.5 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
twilio_php_api_update-2997261-11.patch	4.54 KB

twilio_php_api_update-2997261-12.patch	4.54 KB

twilio_php_api_update-2997261-13.patch	4.66 KB

Updated patch which has a couple more safe guards to not throw fatal errors when the library is not available.

@hoegrammer: I think the problem was that there was an assignment in the if(), which is never a good idea. Also changed that in the patch.

The most annoying thing about this upgrade is that the Twilio library version 5 is now 190k lines of code!! This is huge and I don't want to add all the irrelevant Twilio class files to my composer classmap. I decided to use it with the libraries API instead.