I wanted the tip for Textile ("You can use Textile markup to format text.") to link to the page of the textile tips (/filter/tips/4#filter-textile-0). So I made this patch.

CommentFileSizeAuthor
#4 textile-link-in-tip-966312-1.patch875 bytesAlsciende
#1 textile-link-in-tip-966312-1.patch598 bytesAlsciende

Comments

Alsciende’s picture

Alsciende commented
StatusFileSize
new textile-link-in-tip-966312-1.patch598 bytes

Here is it, very straightforward. Please review.

Alsciende’s picture

Alsciende commented
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

The patch is not in the correct format.

Alsciende’s picture

Alsciende commented
Status: Needs work » Needs review
StatusFileSize
new textile-link-in-tip-966312-1.patch875 bytes

Trying again

Anonymous’s picture

Anonymous (not verified) commented

In the input format fieldset there is already the link More information about formatting options, which points to the page with the extended help for each input format. I am not sure there is the need to include an extra link to that page; other input filter modules don't add similar links in the short tip text, AFAIK.

Anonymous’s picture

Anonymous (not verified) commented

The used fragment doesn't match with the one used on drupal.org, which uses #filter-filter-0; are you sure the patch is using the correct one?

Alsciende’s picture

Alsciende commented

I took the code from the bbcode module ; I don't know anything about #filter-filter-0. My patch is a direct copy of their feature that I found quite useful. Feel free to reject it if you don't think it fits, I just thought you might like it.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (won't fix)

I am changing status as per my comment #5.