when setting limit of terms to be used to 2 and you actually try to set 3 terms
there is multiple messages displayed for EACH and EVERY term in the TREE
1 error message should be enough and too many is BAD UX

look at the attachment for a visual

CommentFileSizeAuthor
#4 term_reference_tree-2843509-4.patch1.05 KBtimwood
#2 limit-displayed-errors.patch1012 bytespierre-nono
field_group.multiple.errors.png48.1 KBgiorgosk

Comments

GiorgosK created an issue. See original summary.

pierre-nono’s picture

pierre-nono commented
StatusFileSize
new limit-displayed-errors.patch1012 bytes

Here is a patch to solution this simply.

The problem is that the form use the attribute #tree without removing the attribute #errors for the children elements, which in result will flag every element with errors.

It works with custom validation too.

Credits to defr

alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Active » Needs review
timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented
StatusFileSize
new term_reference_tree-2843509-4.patch1.05 KB

Here's an updated patch for latest release (1.0) and current -dev.

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented
jonraedeke’s picture

jonraedeke commented
Status: Needs review » Reviewed & tested by the community

We've been using this patch for a long time without issue. RTBC

  • VladimirAus committed 106f792 on 8.x-1.x authored by timwood 
    Issue #2843509 by timwood, pierre-nono, GiorgosK, alex_optim, jonraedeke...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.