$form .= implode(module_invoke_all("taxonomy", "form", "vocabulary", $edit));
should be
$form .= implode(module_invoke_all("taxonomy", "form", "vocabulary"), $edit);

and
$form .= implode(module_invoke_all("taxonomy", "form", "term", $edit));
should be
$form .= implode(module_invoke_all("taxonomy", "form", "term"), $edit);

I will anticipate the patch released for image, weblink and forum.
BTW, please add filestore2 in TODO.

Comments

axel’s picture

No, this is not a typo. Look at realization of 'module_invoke_all' (includes/module.inc). In our case $edit transfer info about term to 'term_access_taxonomy' function (parameter $obj in 'term_access_taxonomy').

I plan to patch 'filestore2' and some other modules from contribs in near future (next week I think).

tienying’s picture

So you want to pass one parameter in implode().

From php manual:
http://www.phpfreaks.com/phpref/110.php

string implode ( [string glue, array pieces])

Note: As of PHP 4.3.0, the glue parameter of implode() is optional and defaults to the empty string('').

It would be better to put '' in implode for the PHP 4.2.x compatibility. Or it would produce run time error as my case.

Sorry that I am not the php programmer. Maybe I am incorrect.

axel’s picture

Me too not a PHP-programmer :) I'm not very expirienced with compatibility issues of different PHPs. Ok, empty strings added to implode() in taxonomy.patch, now it must be compatible with PHP 4.2. Thank you for pointing to this problem.

Anonymous’s picture