This gave me some pain for a day so I thought I'd mention it. When I apply the "Taxonomy Subterms" setting to "infinity" it shows no subterms. If i change this to a number value it works. If I get time I might try to find the source of the problem.

CommentFileSizeAuthor
#4 inifinitysubterms-1182508-4.patch609 bytesIgnigena

Comments

TimelessDomain’s picture

TimelessDomain commented

nested trees to show depth would be great

Ignigena’s picture

Ignigena commented

I am experiencing this same issue. Under "Infinity" no subterms or nodes show up. When I choose a number the subterms show up but no nodes and I get the "no content classified with this term"

manos_ws’s picture

manos_ws commented
Title: Infinity setting » Infinity setting & module doesnt display subterm nodes in parent taxonomy page
Priority: Normal » Critical

I have the same problems

1. When you choose Infinity no subterms show up in subterm map and no nodes in the taxonomy page

2. When you choose any depth the subterms appear in subterm map but no nodes in the taxonomy page.

The second issue makes this module unusable.

Is this module abandoned. Its over a year since there is a commit

Ignigena’s picture

Ignigena commented
Status: Active » Needs review
StatusFileSize
new inifinitysubterms-1182508-4.patch609 bytes

I have attached a patch that fixes the issue with the Infinity setting showing no subterms.

Apparently, when calling taxonomy_get_tree() if you pass a NULL value to $max_depth it interprets it as 0 and thus is the reason for displaying no subterm map. To solve this, the $max_depth in taxonomy_get_tree() needs to not be set at all. What I did was just do add a quick check on whether or not $depth (in the taxonomy_subterms_term_page() of this module) is NULL and if so, it only passes two variables to taxonomy_get_tree() instead of three.

Here's the code I went with (line 68 of taxonomy_subterms.page.inc):

$map = ($depth == NULL) ? taxonomy_get_tree($term->vid, $term->tid) : taxonomy_get_tree($term->vid, $term->tid, $depth);

Patch attached to this comment.

As far as the second issue with no nodes displaying on the taxonomy page. I did some further testing and it seems that this module was never made to recursively search through subterms and display nodes that may be tagged with subterms. All it does is display the taxonomy tree and whatever nodes are tagged with the main taxonomy term you happen to be browsing now.

It should be an easy task to add in this functionality (and one I would find incredibly useful as well.) This should probably be added as a configurable option so it can be turned on or off since it could add some resource usage for sites with a complicated taxonomy structure.