Hi,

Please find the list of Drupal coding standard issue.

FILE: /root/repos/pareviewsh/pareview_temp/taxonomy_entity.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
--------------------------------------------------------------------------

Time: 23ms; Memory: 4Mb

Codespell has found some spelling errors in your code.

./src/Form/TermForm.php:23: hierachy ==> hierarchy
./src/Form/TermForm.php:24: hierachy ==> hierarchy
./src/Form/TermForm.php:28: hierachy ==> hierarchy
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: /root/repos/pareviewsh/pareview_temp/src/Form/VocabularyForm.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
17 | ERROR | [x] Expected "\Drupal\taxonomy\VocabularyStorageInterface"
| | but found
| | "\Drupal\taxonomy\VocabularyStorageInterface." for @var
| | tag in member variable comment
83 | ERROR | [x] Expected 1 blank line after function; 0 found
84 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Form/OverviewTerms.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Form/TermForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
28 | ERROR | [x] Expected 1 space after IF keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...pos/pareviewsh/pareview_temp/src/Routing/TaxonomyRouteSubscriber.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
21 | ERROR | [x] Expected 1 newline at end of file; 0 found
21 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/taxonomy_entity.services.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/taxonomy_entity.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
8 | ERROR | [x] There must be one blank line after the last USE
| | statement; 2 found;
14 | ERROR | [x] Expected 1 blank line before function; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 119 characters
----------------------------------------------------------------------

Comments

pvsureshmca created an issue. See original summary.

pvsureshmca’s picture

StatusFileSize
new3.74 KB

Hi,

I have added patch to the above coding standard issue.

Please review it.

pvsureshmca’s picture

Assigned: pvsureshmca » Unassigned
Status: Needs work » Needs review
jefuri’s picture

Status: Needs review » Closed (outdated)

Already fixed

pvsureshmca’s picture

Status: Closed (outdated) » Needs work
StatusFileSize
new130.13 KB

Hi

Look at below image.

issue

pvsureshmca’s picture

StatusFileSize
new43.81 KB

Hi,

I don't know, How it will be outdated. Please refer your commits and refer my created date. without the report, I don't like to add the patch.

issue

jefuri’s picture

Status: Needs work » Fixed

I did not apply your patch, we already fixed it in the project that we use this module in. I saw your issue only afterwards.

Thank you for trying to help.

jefuri’s picture

Status: Fixed » Closed (fixed)