Problem/Motivation

Based on the https://www.drupal.org/project/drupal/issues/3308890.

The stable theme is deprecated and will be removed from Drupal 10. Themes depending on the stable theme may use the stable contrib project or switch to stable 9.

Steps to reproduce

1. Use Drupal 9.5 clean website
2. Follow readme.txt download the tailwindcss theme project
3. Enable the theme and check the status report.

Proposed resolution

Set stable project as dependency theme.

Remaining tasks

Update composer.json

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#14 base-theme-change-3330727-14.patch409 bytescsakiistvan
#5 base-theme-change-3330727-5.patch368 bytescsakiistvan
#2 base-theme-change-3330727-1.patch514 bytescsakiistvan

Issue fork tailwindcss-3330727

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 5.x Comparechanges, plain diff MR !6
About issue forks

Comments

cobenash created an issue. See original summary.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review
StatusFileSize
new base-theme-change-3330727-1.patch514 bytes

I fixed the D10 compatibility issue too.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Stable theme is deprecated themes after 9.5 » Stable theme is deprecated after Drupal 9.5
Version: 5.0.0-alpha2 » 5.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

core cannot be used with that core_version_requirement value.

Either that value is changed, or the patch just corrects the base theme value, which is the topic of this issue.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new base-theme-change-3330727-5.patch368 bytes

Thank you apaderno for the feedback. I updated the patch and it is modify only the topic of this issue.

cobenash’s picture

cobenash
Location Taipei
commented

@apaderno @csakiistvan Thank you !

However, the original issue I reported will be added stable theme as dependency theme.

Therefore, I guess we probably needs to add composer.json and add stable theme in require section.

Also, we might need to change the installation process in readme.txt. Using composer instead of git clone.

cobenash’s picture

cobenash
Location Taipei
commented
Status: Needs review » Needs work
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Postponed

The Readme update is on an another issue https://www.drupal.org/project/tailwindcss/issues/3197085. The composer is a good idea, we should create a new issue for this. What do you think cobenash?

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Issue tags: +GlobalContributionWeekend2023
cobenash’s picture

cobenash
Location Taipei
commented

@csakiistvan Thank you.

I am okay with opening another new issue for supporting composer.json.

But the current issue will not be fixed for now. Because stable theme is the base theme of the tailwindcss theme.

About the composer.json format, I think we could use the following format.

{
	"name": "drupal/tailwindcss",
	"type": "drupal-theme",
	"description": "A starter kit theme for Drupal 8/9 and Tailwind CSS.",
	"homepage": "https://www.drupal.org/project/tailwindcss",
	"license": "GPL-2.0+",
	"require": {
		"drupal/stable": ">=2.0.0"
	}
}

Although the themes project will be moved to contrib folder if we use composer, but we could add some script to clone a new one on the custom foler.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan

Yes, you are right. I misunderstood the task, I am on it.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Postponed » Needs work

@cobenash do you mean the tailwindcss theme should be move to the themes/custom folder right? There is a vendor-dir option in the composer, we should use this for that


{
	"name": "drupal/tailwindcss",
	"type": "drupal-theme",
	"description": "A starter kit theme for Drupal 8/9 and Tailwind CSS.",
	"homepage": "https://www.drupal.org/project/tailwindcss",
	"license": "GPL-2.0+",
	"require": {
		"drupal/stable": ">=2.0.0"
	},
  "config": {
    "vendor-dir": "../../custom/tailwindcss"
  }
}
cobenash’s picture

cobenash
Location Taipei
commented

@csakiistvan

No, I mean if we use composer to download the theme, drupal will put the theme directly at the theme/contrib folder. But it's fine.

Instead, I think we should create a basic shell script, copy the theme from theme/contrib/tailwindcss to theme/custom/mytheme

Also, update the theme name and corresponding file name.

For example, mytheme might be the new custom tailwindcss.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new base-theme-change-3330727-14.patch409 bytes

I think It looks like a new feature request. Should I create a new issue for this?
I attached the updated patch

cobenash’s picture

cobenash
Location Taipei
commented

@csakiistvan Thank you for your patch.

From my end, I think the script is necessary. Here is the example I found from bootstrap_sass https://git.drupalcode.org/project/bootstrap_sass/-/blob/5.x/scripts/cre...

Or we need to update the readme.txt to write the correct step if we want to use composer download the project.

It's just my point of view. :)

gambry’s picture

gambry
Primary language Italian
Location Milan
commented
Issue tags: +ContributionWeekend2023

Adding the correct tag for Drupal Global Contribution Weekend 2023.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Issue tags: -GlobalContributionWeekend2023

SerShevchyk made their first commit to this issue’s fork.

SerShevchyk opened merge request !6

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

I think it's also worth testing this with base theme: false and seeing if it works without a base theme.

markconroy’s picture

markconroy commented
Status: Needs review » Closed (outdated)

We have also worked on the "Stable is deprecated" issue in #3465786: Add support for Drupal 11 where we set Stable9 as the theme, so we are not relying on a contrib theme, and also updating from core to core_version_requirement.

For that reason, I think this issue could probably be closed as outdated since it doesn't reflect support for D11.