Comments

opdavies created an issue. See original summary.

opdavies’s picture

Title: Add some default tab styling » Add default tab styling
Issue summary: View changes

.

behindthepage’s picture

Status: Active » Needs review
StatusFileSize
new2.22 KB

I have recently downloaded this theme and this one of the first things I did. Patched attached for review.

behindthepage’s picture

StatusFileSize
new3.88 KB

Revised patch attached with extra theming for secondary links.

opdavies’s picture

Thanks, @behindthepage!

I've tested this out on my personal site and it looks good.

Only local images are allowed.

I'll double-check, but I don't think that we need the tw- prefix though as it should have been removed in the 4.x branch. I don't see it in https://git.drupalcode.org/project/tailwindcss/-/raw/4.x/dist/tailwind.css, for example, but I'll try it with a plain Drupal installation and see what happens.

behindthepage’s picture

Yes, sorry I did it on the 2.7 branch.

While the tw- prefix is a bit of a pain I thought it was a good idea to differentiate the Tailwind classes from anything Drupal generated.
Have you found that not to be a problem?

Regards
Geoff

opdavies’s picture

Status: Needs review » Needs work

I haven't found it to be an issue on my site and the ones that I've used the non-prefixed Tailwind on.

We should probably add something for responsive tabs in this issue too. This patch is a great starting point but is just adding styles for desktop as far as I can see.

behindthepage’s picture

Good point.
I am not sure when I will get back to this so you might like to add this to the repo so there is at least some styling on the tabs and we can add to it later.

  • opdavies committed 064445d on 4.x
    Issue #3163456 by behindthepage, opdavies: Add default tab styling
    

  • opdavies committed c6e0b8c on 8.x-3.x
    Issue #3163456 by behindthepage, opdavies: Add default tab styling
    

  • opdavies committed 6187eff on 8.x-2.x
    Issue #3163456 by behindthepage, opdavies: Add default tab styling
    
opdavies’s picture

I've added some basic list styling with the list-disc and list-inside classes as a minimal solution.

Further styling can be added in a separate issue.

opdavies’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.