Hi and thanks for your module!

I was trying it out and it seems that part of the code that sets and gets cookies is not working correctly. The tabs always go back to the default state on reload.

I tried on both FF and IE, and the results were the same. Any ideas?

CommentFileSizeAuthor
#3 tabbed_block.js_.txt3.46 KBbcn

Comments

bcn’s picture

bcn commented

After a bit of testing I found at least 2 things that are keeping the cookies from working.
First is that the wrong cookie value is being set in the tabbed_block_tab function.
Second is the code to trigger the link back to the previous state was removed from the lastest releases. This could be intentional, but it seems to not work at all without it. The line that had been removed was:

    $(this).find(".tabbed_block-nav").children("li").eq(frag.substr(-1)).trigger("click");
joetsuihk’s picture

joetsuihk commented
Assigned: Unassigned » joetsuihk

confirmed bug.
thanks a lot

working on patch.

bcn’s picture

bcn commented
StatusFileSize
new tabbed_block.js_.txt3.46 KB

Sorry I can't roll a patch right now, but I attached a copy of the js file that is now working.

joetsuihk’s picture

joetsuihk commented
Status: Active » Fixed

committed to head

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.