As a test I ported the current version to d 8.
I have no sites running d8 and this service, so please test this.
You can find the patch attached.
Can you pls make a d8 branch?
If you add me as a contributor I will push it right away.
| Comment | File | Size | Author |
|---|---|---|---|
| system_status_8.x-1.x.patch | 40.32 KB | wouters_f |
Comments
Comment #1
sam hermans commentedNew maintainer drupal_sensei added and permissions updated ! ;)
Comment #2
wouters_f commentedcommitted in http://drupalcode.org/project/system_status.git/commit/f6548b07c132dabb3...
Please test
Comment #3
sam hermans commentedDo you have an online / reachable website running drupal8 that can be reached by the system ? I'm not seeing any drupal8 modules in the backend
Comment #4
wouters_f commentedI have now, available at http://it2servu.be/d8
Added system status module and enabled it (after some minor changes, pushed to 8.x-1.x).
Pushed to drupalstatus.org and it keeps 'Please wait a minute or two for our servers to generate a report.'
Do I overlook something?
Comment #5
sam hermans commentedFinaly picking up development on Drupalstatus again ..
So i just created a dev release on drupal.org so more users have access to the patch you created.
If i check the database for your site i cannot find a 'site-token' or 'site-encryption-token'. My first guess is that this is related to the way you are redirected to the drupalstatus.org site coming from the settings form.
For some strange reason i was able to fetch some information from your site since it knows you have the entity and system_status modules.
Will check your branch now on a local d8
Comment #6
sam hermans commentedComment #7
sam hermans commentedWhen i try to enable the module i get
[Wed Jan 15 19:36:31 2014] [error] ] PHP Fatal error: Class 'SystemStatusEncryption' not found in **/drupal8/modules/system_status/system_status.install on line 34, referer: http://*****/admin/modulesand my installation is broken .. any luck on your end ?
Comment #8
sam hermans commentedOkay, so everything works. I changed everything to the new Config system, and to the new ways of getting the modules.
commit here
The last thing we have to do now to finish the module is the token on the report route.. So the normal report url is http://**/admin/reports/system_status/.
This doesnt work, but without the token it works. This means that all sites that use it now are 'open' to public. (the information is still encrypted).
In d6 and d7 this was handled with an access callback.
Comment #9
sam hermans commentedAccess control is now fixed. A new service is created.
Token (and IP) verification needs to be added in lib/Drupal/system_status/Access/SystemStatusAccessCheck.php
We need to compare
$request->attributes->get('_raw_variables')->get('system_status_token') with $config->get('system_status_token);And clean up the unused system_status_access_callback in system_status.module
commit here
Comment #10
sam hermans commentedComment #11
sam hermans commented