In swftools exists a module with the same name. I checked the CVS and it appears that this module was developed later. I suggest that you change the name of this module to prevent conflicts with the one in swftools that was there earlier.

For instance, Blue drop video module depends on this module and on swftools, but since it conflicts with the flowplayer module in swftools, this module won't even appear in the modules page. I had to delete the swftools flowplayer to make it work.

Comments

robloach’s picture

robloach
he/him
commented
Title: name conflict with swftools » Naming conflict with Flowplayer module
Project: Flowplayer API » SWF Tools
Version: 6.x-1.x-dev » 6.x-2.x-dev
Component: Code » SWF Tools

The Flowplayer Drupal module is not changing its name. SWF Tool's Flowplayer module will have to change as that's a sub-module. Looking at the source, it seems like SWFObject module is a candidate for this problem as well.

Renaming SWF Tool's Flowplayer module to "swftools_flowplayer" and "swftools_flowplayer3" will solve the problem. Another thing we could do is move the SWF Tools module hooks over to the Flowplayer module and integrate the two? Thanks.

jbrown’s picture

jbrown commented
Issue tags: +namespaces

tagging

jbrown’s picture

jbrown commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Stuart Greenfield’s picture

Stuart Greenfield commented

I've picked this up and am in the process of correcting it for the 6.3 release.

You're right that this is a wider issue since all the child modules of SWF Tools don't use an swftools_ prefix to avoid name space collisions. So I'm implementing the fix in all modules before going any further to get things back on the right track.

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Needs review

Committed on DRUPAL-6--3. I have gone through and manually corrected all modules and constants to the swftools namespace. I've not run full tests on all the modules yet as I'm still restoring my development rig and don't yet have all the players back, but the change was fairly simple so fingers crossed I got it right.

If anyone is able/willing to test the new set up and post their results here that would be a big help!

jbrown’s picture

jbrown commented

Really glad your working on this Stuart!

fluxrider’s picture

fluxrider commented

I'll test this w/e and get back to you here, probably sunday.

jbrown’s picture

jbrown commented
Title: Naming conflict with Flowplayer module » Naming conflict with Flowplayer API module
Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Needs review » Reviewed & tested by the community

All SWF Tools modules are now part of the swftools_ namepsace.

cooldeeponline’s picture

cooldeeponline commented

yeah like the description states .... deleting the flowplayer modules from the swf tool folder seems to be the only way by which the flowplayer api shows up in the module page...