Closed (fixed)
Project:
Support Ticketing System
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2010 at 20:11 UTC
Updated:
6 May 2010 at 07:10 UTC
When building the menus for clients a local variable called $states which holds all states, plus all, all open, my open is assigned value in a while loop which is not necessary (statuses are global, not per individual client). Some variable values are fetched from the DB which causes unnecessary reads with lots of clients.
The same variable is assigned the same value (except the my open state) shortly after to build the menu for "ticket's assigned to user X".
Attached is patch against CVS HEAD which assigns the value of this variable only once thus slightly improving performance.
| Comment | File | Size | Author |
|---|---|---|---|
| support-states-array-optimization.patch | 1.42 KB | atodorov |
Comments
Comment #1
jeremy commentedFix applied, thanks!
http://drupal.org/cvs?commit=357926