Closed (fixed)
Project:
Support Ticketing System
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
2 Jul 2009 at 12:47 UTC
Updated:
9 Aug 2010 at 02:17 UTC
Jump to comment: Most recent file
Comments
Comment #1
court-jus commentedhere is a patch, please comment :-)
Comment #2
jeremy commentedI like the idea very much. However, I think the patch needs quite a bit more work. Some feedback:
1) Please don't use tabs in your code, stick with the existing coding style which uses spaces.
2) The drop-down needs to respect the module settings and turn into an autocomplete text field if there are too many users available for assigning the ticket to. Otherwise you're going to end up with a white screen when PHP runs out of memory trying to load thousands of users.
3) Rather than have an "OK" button on each row, it would be better to have one at the bottom of the page (or at the top of the page, or both) so you can update multiple assignments at once, and to offer less clutter to the table. This button should also be named something else, 'Update assignments' or something else that's more descriptive.
4) Your error messages are confusing. I assume the goal of these "locks" is to prevent two people from changing the assignment of the same ticket?
5) I want to know when tickets are changing and who is changing them. If userA adds a comment to ticket1, then adminZ comes along and assigns the ticket to userB, it will look like userA assigned the ticket to userB. There will be no record of adminZ having done anything. I think it would be better to create a comment with a default value when changing the assignment. Actually, much better would be if at the bottom of the page where you'll put the renamed 'OK' button you could also put a textfield allowing the admin to add a message to all modified tickets. It'll also be important to show a "Suppress notification" checkbox as well allowing admins to prevent emails from being sent out when the ticket is updated.
6) When a user is assigned to a ticket, they should also be subscribed to it so that they receive notifications. I believe the changes I describe in #5 will address is automatically.
7) Why not offer drop-downs for the priority and state as well?
Comment #3
court-jus commentedwow that is a review
about 7) : just because we didn't need it but... why not
about the rest : that's why I needed review, that's a quick and dirty patch and you ask me to make it a clean one :-) I will try to
Comment #4
c0psrul3 commentedbump
Comment #5
neubreed commentedI think this is a good idea. Having to edit or post a message to assign a ticket is a bit long winded.
Comment #6
3dloco commented+1 :-D
Comment #7
jeremy commentedUpdated the ticket overview to be a form and to allow selecting/updating multiple tickets:
http://drupal.org/cvs?commit=356482
Currently it's only possible to add a ticket update, and modify the state or priority. The ability to update ticket assignments will come next.
Comment #8
jeremy commentedComment #9
jeremy commentedAdded ability to change the assignment, too.
http://drupal.org/cvs?commit=356526
Comment #11
izmeez commentedI came across this issue and thought it might help me understand the purpose of the "Update" field at the bottom of the view of tickets when viewed by an admin. I was wondering why it is set to required and I think item 5 in comment #2 above explains it. To force a comment to be recorded so that it can reflect changes to assignment, priority, etc.
If this is a required field I wonder if there might be a way to present the field with a default one line which can be used or deleted and replaced. The one line might also help make it more understandable why this field is here and also why it is required. I haven't come up with such a line.
I hope it is ok for me to post to this issue even though it is closed as it seems to be the only issue related to this item and makes it easier for me to explain what I am wondering about. I could open this as a separate issue if that would be better.
Thanks,
Izzy