Accidentally the per-client code at the end of hook_permission function is not called because of an early return statement.

Please replace return with $perm = as stated below.

/**
 * Implementation of hook_perm().
 */
function support_permission() {
  $perm = array(

Without this code all non adminstrator ticket assignments are broken.

Comments

bdragon’s picture

bdragon commented
Status: Needs review » Fixed

Fixed, thanks.
f78f06cb09596fcb27a388ffe019b28628b4ede6

bdragon’s picture

bdragon commented

Followup typo regarding the permission name being wrong fixed in 934f79e22395ef2b10c4d73f38cd8171d48aaf15.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

There seemed to be more wrong, because the module finally still didn't work for non admin permissions after that fix.

Also note that i've found several Client access string replacements with different replacement patterns. Some with !client, and others. They should be all identical to work right in case of special chars.

Did you ever check if the project works without administrative permissions?

bdragon’s picture

bdragon commented

There are issues in the code (not 7.x specific) regarding attempting to use client specific permissions with drupal's built in (anonymous / authenticated) roles. Specifically, none of the autocomplete stuff works properly, due to those roles not actually being stored in {users_roles} (they're implicit). It is possible there are further issues regarding this.

I have been testing against an account without administrative permissions today, but not extensively.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.