Having inline JavaScript slows down page loading and rendering. We should be using JavaScript Behaviors inside our own JavaScript file instead.

CommentFileSizeAuthor
#2 1194244.patch8.84 KBrobloach
#1 javascript.patch7.62 KBrobloach
#1 superfish.js_.txt1.05 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new superfish.js_.txt1.05 KB
new javascript.patch7.62 KB

This patch removes the inline JavaScript and uses Drupal settings and a behavior instead. You'll need to place superfish.js in the Superfish module folder.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1194244.patch8.84 KB

Here's a unified patch for it.

joelstein’s picture

joelstein commented
Status: Needs review » Reviewed & tested by the community

This patch worked for me!

mehrpadin’s picture

mehrpadin commented

Hey there,

Thanks Rob! thanks Joel! next version coming soon!

mehrpadin’s picture

mehrpadin commented
Status: Reviewed & tested by the community » Fixed

v1.9-beta3 is out :)

Automatically closed -- issue fixed for 2 weeks with no activity.