$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml supercache/

FILE: C:\Users\SI-001\Downloads\supercache\src\Cache\DatabaseRawBackend.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
133 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
215 | WARNING | There must be no blank line following an inline comment
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 527ms; Memory: 8MB

CommentFileSizeAuthor
#2 unserialize-issue-3296311-2.patch947 bytesrakhi soni

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new947 bytes

Kindly review patch,,

sourabhjain’s picture

Status: Needs review » Reviewed & tested by the community

I have reviewed the patch #2 and it seems it looks fine.
Moving to RTBC

I have found the below error but it is already covered in https://www.drupal.org/project/supercache/issues/3296308

FILE: /Users/sourabhjain/www/2022/drupal/modules/contrib/supercache/supercache.info.yml
---------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
---------------------------------------------------------------------------------------

Time: 235ms; Memory: 10MB