Problem/Motivation

FILE: C:\xampp\htdocs\drupal-9\web\modules\contrib\super_login\super_login.module
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
---------------------------------------------------------------------------------
25 | WARNING | Only string literals should be passed to t() where possible
55 | WARNING | Only string literals should be passed to t() where possible
59 | WARNING | Only string literals should be passed to t() where possible
67 | WARNING | Only string literals should be passed to t() where possible
77 | WARNING | Only string literals should be passed to t() where possible
83 | WARNING | Only string literals should be passed to t() where possible
118 | WARNING | Only string literals should be passed to t() where possible
122 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 only-string-passed-to-3304425-3.patch9.84 KBdharti patel
#2 super_login-3304425-2.patch4.99 KBanoopsingh92

Issue fork super_login-3304425

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anoopsingh92 created an issue. See original summary.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Active » Needs review
StatusFileSize
new super_login-3304425-2.patch4.99 KB

Please review the patch.

dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
StatusFileSize
new only-string-passed-to-3304425-3.patch9.84 KB

Hello,

I've reviewed the #2 patch and after applying the patch below errors are shown:

FILE: /home/drupal/myproject/super_login/src/Super_loginSettingsForm.php
----------------------------------------------------------------------------------
FOUND 3 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------------------
  37 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 132 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------

I have created a new patch to fix the above issues.
Kindly review the patch.

Thanks!