All-zero counts on the Overview tab, replace broken hook_count_user_subscriptions() with hook_subscriptions_counts_alter()

When I wrote that, I had come to the conclusion that it was not feasible to get correct counts, but I don't remember the details.

You're welcome to give it a try...

There is an option in the admin settings to remove it.

Typically it also has user settings on it.

Showing 0 when there are in fact existing subscriptions is a glaring inconsistency — I certainly agree with that —, but it's not the typical case.

Your situation would be worth investigating to see whether the numbers can at least be improved. I thought the Overview numbers tended to be higher rather than lower than the actual counts.

Investigating this remotely will be difficult but let's give it a try.

What numbers are you seeing on the Overview page and what counts are you getting on the other pages?

Name the "other pages" where this occurs. I don't want to stab in the dark.

Sorry, but please name a tab where it's not correct. I don't want to pick one that might later turn out to be one that happens to work...

I see the problem, need to investigate...

Hmm, I was able to reproduce it at some point, but I cannot anymore...

FWIW, it's definitely still occurring for me on 7.x-1.0. The "Overview" tab always shows 0 for each subscription type, despite the fact the the individual subscription tabs have the correct information.

Can you please try the -dev version?

Can you please try the -dev version?

Of course. Unfortunately, the behavior turned out to be the same with the dev version on my system.

Let me know if there's anything I can do from here to help you track it down.

Short of debugging subscriptions_page_user_overview() in subscriptions.admin.inc I don't know what to do.

This requires reproducing the issue...

I'll have a look. I still have a 7.x-1.0 on a test site.

Starting with:

Overview:

Pages/Threads 1
Content Types 1
Categories 0
Blogs 0

Individual Tabs: numbers agree with what's in Overview tab.

1. Adding a Category subscription in Individual tab -> Overview:
Categories 1

2. Adding a Content type subscription from a node -> Subscribe fieldset ->
Back to Overview page
Content Types 2

So, this all adds up.

Are your test users getting subscription notifications for the subscriptions that are not included in the numbers in the Overview tab?

Short of debugging subscriptions_page_user_overview() in subscriptions.admin.inc I don't know what to do.

OK, I'm happy to do that.

The problem is at line 389 of that file (referencing the dev version here). If the Blog Subscriptions UI module is enabled, the overview tab works as expected. If not, the values displayed are always 0. The reason is that the module_invoke_all() routine overwrites the contents of the $counts array whether a matching hook routine was found or not. If one is found, as when the blog submodule is enabled, it returns a valid counts array. If not, it returns an empty array, wiping out the values that had been calculated above. One simple workaround is to use a temporary return variable and conditionally replace the original with it.

Great, thank you, jerry!

It turns out that hook_count_user_subscriptions() was completely broken. It worked only if it was implemented exactly once.

I've replaced it with hook_subscriptions_counts_alter(), which should work correctly now.

Pushed to the -dev version (give it up to 12h to be repackaged).

Please try it out and let us know what you find.

Looks good from here.