got an ugly error message when trying to create a digest template, pointing to line 339 of subscriptions.token.inc ... didn't really expect to see something useful when visiting that file (i am not a 'coder') i went there and discovered the typo in function subscriptions_token_info_alter where it spells
if (empty($massage_tokens))

after changing that to §message_tokens the error disappeared. pls correct it for next release.

thx a lot for your work! spent quite a time to figure out the messaging/notifications module framework but finally gave up and happily turned to subscriptions!

regards from vienna forest
karl

Comments

karing’s picture

karing
Location 🇨🇦
commented

What is the error message you were getting?

$massage_tokens is used consistently throughout the code [line numbers could vary slightly - this is version = "7.x-1.0-beta4+3-dev"] - most notably two lines before the empty() that you edited:

grep -in massage_tokens *
subscriptions.tokens.inc:344:  $massage_tokens = &drupal_static('subscriptions_mail_massage_tokens');
subscriptions.tokens.inc:346:  if (empty($massage_tokens)) {
subscriptions_mail.mail_edit.inc:51:  $massage_tokens = &drupal_static('subscriptions_mail_massage_tokens');
subscriptions_mail.mail_edit.inc:52:  $massage_tokens = FALSE;
subscriptions_mail.mail_edit.inc:65:    $massage_tokens = TRUE;
subscriptions_mail.mail_edit.inc:68:    $massage_tokens = FALSE;
salvis’s picture

salvis
he/his
commented
Status: Active » Closed (cannot reproduce)

No follow-up.

"massage_tokens" is correct — this is a Boolean that says whether we need to massage (yes!) the tokens or not.

Changing it to $message_tokens is definitely wrong!