An image called at

http://dev.example.com/files/styles/thumbnail/public/My%20Folder/photo1.jpg does not work, where the image DOES exist on http://www.example.com/files/styles/thumbnail/public/My%20Folder/photo1.jpg

Is this something that can be fixed?

CommentFileSizeAuthor
#3 stage_file_proxy-fix-spaces-in-folder-1895516-3.patch580 bytesBarisW
#2 stage_file_proxy-fix-spaces-in-folder-1895516-2.patch498 bytesBarisW

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I don't plan to work on this as it doesn't currently affect me, but I'd happily test and apply a patch.

BarisW’s picture

BarisW commented
Title: Images don't show when they have spaces in the filename/folder » Images don't show when they have spaces in folder name
Status: Active » Needs review
StatusFileSize
new stage_file_proxy-fix-spaces-in-folder-1895516-2.patch498 bytes

Sure. Patch attached.

BarisW’s picture

BarisW commented
StatusFileSize
new stage_file_proxy-fix-spaces-in-folder-1895516-3.patch580 bytes

Same error as in #1014470: Use drupal_http_request instead of cURL. Re-roll attached.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Let's get #1014470 done first since I imagine both of these don't apply together.

Does #1014470 also fix this issue by any chance?

BarisW’s picture

BarisW commented

No, I've split them up so you can commit them separately. They are on different lines and work independently.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Thanks, BarisW - committed with you as the --author http://drupalcode.org/project/stage_file_proxy.git/commit/e5aba2e

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs work

Hmmm - can you take a look at #1933538: rawurlencode on file path breaking file fetching ?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Fixed

Let's leave this as fixed since there's a patch at #1933538: rawurlencode on file path breaking file fetching.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

x