Layout basically works with these, the only thing is that the order of regions is currently not saved properly (working on that):

regions: http://drupal.org/sandbox/goba/1782014 (take tip of 8.x-1.x)
bunnypoints: http://drupal.org/sandbox/goba/1784698 (take tip of 8.x-1.x)
http://drupal.org/project/gridbuilder (take tip of 8.x-1.x)
http://drupal.org/project/layout (take tip of 8.x-1.x)
core patch to apply: http://drupal.org/files/1781372-8.patch (hopefuly it still applies to 8.x tip still)

You can save/edit/delete regions, save/edit/delete grids (with the fancy UI from 7), save/edit/delete bunnypoint (and associate grids) and have layouts configured for each bunnypoint/grid with the regions set up.

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Assigned: Unassigned » webchick
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Aloha module (for editing on the back-end):
- core patch to be able to set attributes on script tags: http://drupal.org/files/1664602-1.patch
- filter system core patch + change default text formats: http://drupal.org/node/1782838
- Aloha.module, 8.x-2.x branch

Edit module: coming later.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Started on this now. See http://drupalcode.org/project/spark.git/shortlog/refs/heads/8.x-1.x to track the thrilling progress! :P

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Current errors:

	•	Notice: Undefined index: bunnypoint in install_profile_modules() (line 1512 ofcore/includes/install.core.inc).
	•	Notice: Trying to get property of non-object in install_profile_modules() (line 1512 ofcore/includes/install.core.inc).
	•	Notice: Undefined index: region in install_profile_modules() (line 1512 ofcore/includes/install.core.inc).
	•	Notice: Trying to get property of non-object in install_profile_modules() (line 1512 ofcore/includes/install.core.inc).
	•	Notice: Undefined index: region in install_profile_modules() (line 1520 ofcore/includes/install.core.inc).
	•	Notice: Trying to get property of non-object in install_profile_modules() (line 1520 ofcore/includes/install.core.inc).
	•	Notice: Undefined index: bunnypoint in install_profile_modules() (line 1520 ofcore/includes/install.core.inc).
	•	Notice: Trying to get property of non-object in install_profile_modules() (line 1520 ofcore/includes/install.core.inc).


An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://localhost/spark-git/8xx/core/install.php?langcode=en&profile=spar... StatusText: OK ResponseText: Recoverable fatal error: Argument 1 passed to taxonomy_vocabulary_save() must be an instance of Drupal\taxonomy\Vocabulary, instance of stdClass given, called in /Users/abyron/Sites/spark-git/8xx/profiles/spark/spark.install on line 269 and defined in taxonomy_vocabulary_save() (line 442 of /Users/abyron/Sites/spark-git/8xx/core/modules/taxonomy/taxonomy.module).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Meh. Well the first problem is bunnypoints and regions are sandbox projects, and Drupal.org make files do not support sandbox projects. :\ http://drupal.org/node/1432190#sandbox Created #1785346: Make Bunnypoints into full project. :( and #1785352: Make Regions into full project.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Spark Sprint 5

Also, tagging for this sprint.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Promoted both projects.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Ok, this seems to now be working and not fatalling out on install. YAY!

I found some issues w/ Layouts et al related to recent moving around of Entity stuff: #1785688: Clicking bunnpoint/grid/layout/etc. links cause fatal error.

And Aloha is not loading at all for me. Going to see if I can figure out what's going on there...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Ok, the layouts/breakpoints/grids stuff was fixed by reverting to the older version of the patch that Gábor identified. #1785708: Update listing pages for bunnypoint/grid/layout/region to latest copy of 8.x patch will need to get sorted out sometime.

Also I get these notices on install which I don't on a stock install:


    Notice: Use of undefined constant langcode - assumed 'langcode' in _update_message_text() (line 604 of core/modules/update/update.module).
    Notice: Undefined variable: language in update_mail() (line 518 of core/modules/update/update.module).
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Now blocked on this: #1785732: Aloha causes JS console error in Firefox, but works fine.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

The langcode bug is a good find :) Opened #1785966: Missing $language in update_mail() for that.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

The update_mail() issue now has a patch, needs tests probably: #1785966: Missing $language in update_mail()

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Updated ALL the config entity based modules (Layout, Region, Gridbuilder and Bunnypoint) to rely on the latest entity listing patch (http://drupal.org/files/listing-1781372-42.patch), updated the install profile code as well, so nothing to do here, just FYI. It let us loose the listing class in all modules, since the default is now much smarter but we needed to implement a URI callback for each entity. I also put in some minor code cleanup / type hinting, etc. to the modules.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Just re-built the 8.x release tonight. The new error during install is:

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://localhost/spark-git/8xx/core/install.php?langcode=en&profile=spark&id=1&op=do_nojs&op=do StatusText: OK ResponseText: ( ! ) Fatal error: Class 'Drupal\config\ConfigEntityListController' not found in /Users/abyron/Sites/spark-git/8xx/core/modules/config/config.module on line 37

I'm guessing this got moved to Entity. Stay tuned. :P

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Oh, sheesh. :) Nevermind. It's important to git pull --rebase before running drush make build-spark.make.

Aloha's still not workin' though. :(

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: webchick » wim leers

Ok, I cry uncle. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical

Also, escalating to critical. Since our work is largely happening in D8 these days, I think it's important to provide visibility around this and to give people something to test.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: wim leers » webchick
Status: Active » Fixed

YAY! Wim helped me figure this out. :D I needed to remove the URL filter and Line break filter from spark.install.

Rolled a dev release of 8.x. HOORAY!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Moving to appropriate version now that that is actually possible.

Automatically closed -- issue fixed for 2 weeks with no activity.