Using the setting, "place spam into special review queue, notify visitor" (for what to do with comments auto-marked as spam) does not actually seem to place the contents into a queue.

The spam_scan() function has the following comment where there would be code for that option:
// TODO: SPAM_ACTION_HOLD

It would probably be better to just leave this option out of the user interface until implemented, rather than providing an option that does not do what it says it does...

CommentFileSizeAuthor
#2 spam-remove_hold_option-p0.patch1.31 KBgnassar

Comments

luusl’s picture

luusl commented

Ah, this explains why I never found any prevented spam comments in the list. Also affects 6.x

gnassar’s picture

gnassar commented
Version: 5.x-3.0-beta1 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new spam-remove_hold_option-p0.patch1.31 KB

Good point. The "hold" functionality has been listed but unimplemented for quite a while. Patch removes "hold" option.

AlexisWilke’s picture

AlexisWilke commented
Status: Needs review » Reviewed & tested by the community

I like the idea of adding the index to all the entries in the array! Long term it is much safer.

Thank you.
Alexis

gnassar’s picture

gnassar commented
Status: Reviewed & tested by the community » Fixed

Committed.

http://drupal.org/cvs?commit=470898

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.