Closed (fixed)
Project:
Spam
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Oct 2007 at 11:58 UTC
Updated:
12 Dec 2007 at 14:32 UTC
Jump to comment: Most recent file
Near the end of spam_tokens_unsave I think there's a typo ($probility):
// updating an existing token
$total = $new->spam + $new->notspam;
if ($total == 0) {
$probability = 0;
}
else {
$probility = ($new->spam / $total) * 100;
$probability = spam_get_probability($probability);
}
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | spamtypo.txt | 584 bytes | nancydru |
Comments
Comment #1
nancydruPatch is included in http://drupal.org/node/175080
Comment #2
jeremy commentedPlease keep patches self-contained. Do not bunch multiple fixes together in one issue, as it becomes a headache to review anything. One fix per issue.
Ideally, submit a tiny patch for this issue (or I'll fix it manually, as it's obviously a bug), and then fix your patch in the other issue to only address that issue.
Comment #3
nancydruI was there anyway. But I backed it out of the other patch. It's a simple one liner.
Comment #4
nancydruPatch is to the Oct 18 code.
Comment #5
jeremy commentedUgly typo. Thanks Nancy, fix applied.
Comment #6
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.