The attached patch is the first step to restructuring the admin settings for the Spam module. The main admin page now starts with some intro text (Jeremy, you might notice something else I did for your and my plans). The current settings are now split into four tabs which can be used independently.

The patch also includes the missing "ID" for the module file. There are a few formatting changes for consistency and readability, which unfortunately make this patch bigger than it should be.

There will be follow-on patches to finish the restructuring. I'm doing it in steps to keep the size of each down.

CommentFileSizeAuthor
#3 spam_admin4.txt10.72 KBnancydru
#2 spam_admin3.txt8.08 KBnancydru
#1 spam_admin2.txt6.7 KBnancydru
spam_admin1.txt39.17 KBnancydru

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new spam_admin2.txt6.7 KB

Step 2 is based on step 1 being done. This one moves the custom filters and URL filters to the main admin page and then moves the remaining logging display to the Logs section of the admin menu.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new spam_admin3.txt8.08 KB

Step 3 is some cleanup stuff. Put content type filters into a fieldset. Fix small problem with help text and add a bit more help. Reduce number of decimals on probability logging message. Fix error in "skipping node" log message.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new spam_admin4.txt10.72 KB

Drat, missed some links.

jeremy’s picture

jeremy commented

When I apply the first patch, I'm no longer able to access the administrative pages. Is the idea that all 4 have to be applied at once for things to work? If so, why is it split into 4 patches?

I've finally found time to start reviewing them. They're large, but so far looking good. Well, other than the fact that things stop working when I apply the first one.

jeremy’s picture

jeremy commented

Why are you reformatting all the arrays and such from

  one   => 1,
  two   => 2,
  three => 3,
  four  => 4,

to:

  one => 1,
  two => 2,
  three => 3,
  four => 4,

I find it very annoying when large patches do unnecessary white spaces changes, especially when they make it harder to read the code.

Please keep your changes functional.

jeremy’s picture

jeremy commented
Status: Needs review » Fixed

Okay, the end result is worth it. Very nice. I merged all four patches. Thank you for the time you put into this! (And my sincere apologies for taking so long to finally look at it.)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I don't recall removing the excess spacing; it may have been Dreamweaver "helping" me.

I did email you the full change as a single patch. It worked for me at each stage. I did it in pieces to try to keep the size down (unsuccessfully) and wanted to make sure everything was going okay as I did them.

jeremy’s picture

jeremy commented

I suggest not using Dreamweaver to create patches -- all the extra white space changes makes for a lot of noise. It also makes the code less human readable, imo.

In any case, the end result was very nice and is merged. Thanks again for your contribution -- I'll try and be more responsive the next time you contribute a patch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)