The issue initially reported in #3609300 is still present in 1.0.36:

Uncaught PHP Exception TypeError: "str_contains(): Argument #1 ($haystack) must be of type string, array given" at .../drupal11/web/themes/solo/src/Hook/SoloThemePreprocessHooks.php line 1040

Attached is a proposed fix.

CommentFileSizeAuthor
solo_filebrowser_compat.patch544 byteslpsolit

Comments

lpsolit created an issue. See original summary.

  • flashwebcenter committed fcb14ddc on 1.0.x-dev 
    Issue #3630728 by lpsolit: restore array guards on id and #name lost in...

  • flashwebcenter committed fcb14ddc on 1.0.x 
    Issue #3630728 by lpsolit: restore array guards on id and #name lost in...
flashwebcenter’s picture

flashwebcenter
he/him
Primary language English
Location Austin TX
commented
Status: Needs review » Fixed

Hello,

Thank you for the report and the patch. You were right: this is a regression of #3609300. The fix from 1.0.35 was
lost when the theme code moved into hook classes for Drupal 12.

It is fixed in 1.0.x-dev now, with a test so it cannot come back. The fix also handles an empty or keyed array,
which the [0] patch would not. It will be in the next release, 1.0.38.

Best wishes,
Alaa

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • flashwebcenter committed 3da7c213 on 1.0.x-dev 
    Issue #3630728: run the array-guard test on PHPUnit 9 (Drupal 10)...

  • flashwebcenter committed 3da7c213 on 1.0.x 
    Issue #3630728: run the array-guard test on PHPUnit 9 (Drupal 10)...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.