FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\sms_every8d\src\Plugin\SmsGateway\Every8d.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
89 | WARNING | Unused variable $sms_result.
-------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 Screenshot 2022-07-12 at 12.12.49 PM.png167.6 KBgayatri chahar
#2 unused-variable-3295434-2.patch531 bytesHarsh panchal

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new unused-variable-3295434-2.patch531 bytes

I have fixed this issue and providing a patch.

gayatri chahar’s picture

gayatri chahar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2022-07-12 at 12.12.49 PM.png167.6 KB

#2 patch applied successfully. LGTM

gloomcheng’s picture

gloomcheng commented
Version: » 1.0.x-dev
Assigned: Harsh panchal » Unassigned
Status: Reviewed & tested by the community » Closed (won't fix)

Thanks @harsh-panchal and @gayatri-chahar.

I need $sms_result to fetch response message from every8d gateway and assign it to SmsDeliveryReport by setMessageId(), so it would not a bug actually. I will push a commit for it soon.