Closed (fixed)
Project:
Smart Date
Version:
8.x-2.8
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2020 at 17:13 UTC
Updated:
6 Sep 2020 at 18:39 UTC
Jump to comment: Most recent
I attended your session during DrupalCamp Colorado last weekend and have been giving smart date module a try. It looks really good and I like the user friendly-ness. I did run into an issue with smart date module - recurring dates - when using Olivero [new D9 theme - also runs on D8 sites] theme. One of our team looked into it and we have a small patch:
Error: [] operator not supported for strings in olivero_preprocess_form_element_label() (line 259 of /var/www/drupal/web/sites/default/themes/olivero/olivero.theme)
root@94ecc520c552:/var/www/drupal# composer require 'drupal/smart_date:^2.8'
enable Smart Date and Smart Date Recurring
Create Content Type with a Smart Date Recurring field
Save
Try add /node/add
Produces -> Error (see above)
Patch -> attached();
| Comment | File | Size | Author |
|---|---|---|---|
| smart_date.patch | 1.04 KB | karing |
Comments
Comment #2
mandclu commentedI appreciate the feedback, and the suggested fix. Contributions are always most welcome, though I should point there are patch naming conventions which are also very helpful.
I'll get this merged in, and probably try to get new releases up soon.
Comment #5
mandclu commentedComment #6
karingThank you for merging and sorry about the patch naming!
Comment #7
mandclu commentedNo problem! Also, if it's easier next time you could also try creating a merge request, if that would be easier.