I attended your session during DrupalCamp Colorado last weekend and have been giving smart date module a try. It looks really good and I like the user friendly-ness. I did run into an issue with smart date module - recurring dates - when using Olivero [new D9 theme - also runs on D8 sites] theme. One of our team looked into it and we have a small patch:

Problem/Motivation

Error: [] operator not supported for strings in olivero_preprocess_form_element_label() (line 259 of /var/www/drupal/web/sites/default/themes/olivero/olivero.theme)

Steps to reproduce

root@94ecc520c552:/var/www/drupal# composer require 'drupal/smart_date:^2.8'

enable Smart Date and Smart Date Recurring
Create Content Type with a Smart Date Recurring field
Save

Try add /node/add
Produces -> Error (see above)

Proposed resolution

Patch -> attached();

CommentFileSizeAuthor
smart_date.patch1.04 KBkaring

Comments

KarinG created an issue. See original summary.

mandclu’s picture

Status: Active » Reviewed & tested by the community

I appreciate the feedback, and the suggested fix. Contributions are always most welcome, though I should point there are patch naming conventions which are also very helpful.

I'll get this merged in, and probably try to get new releases up soon.

  • mandclu committed 72b6c8c on 3.0.x authored by KarinG
    Issue #3166156 by KarinG, mandclu: Fix for Error: [] operator not...

  • mandclu committed 0c0ed89 on 8.x-2.x authored by KarinG
    Issue #3166156 by KarinG, mandclu: Fix for Error: [] operator not...
mandclu’s picture

Status: Reviewed & tested by the community » Fixed
karing’s picture

Thank you for merging and sorry about the patch naming!

mandclu’s picture

No problem! Also, if it's easier next time you could also try creating a merge request, if that would be easier.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.