Closed (fixed)
Project:
Slick extras
Version:
8.x-1.0-rc6
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Dec 2021 at 09:26 UTC
Updated:
21 Oct 2022 at 10:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mably commentedComment #3
mably commentedComment #4
mably commentedComment #5
gausarts commentedThank you.
Sorry for inconvenience. I was too excited upgrading to D10, and forgot the minimum D8 :)
In the meantime, downgrading to RC4 is best for D8.
RC5 to support Native Grid at Blazy 2.5+ as noted at project home.
So RC4 is the max for D8.
You can set strict constraints to RC4 at your composer.json to avoid errors till you have time to upgrade to D9.
The versions are just the same in essense.
I could not create new branches since they cost me more time. But indeed we should fix this.
Patches are welcome. Thanks.
Comment #6
mably commentedComment #7
gausarts commentedThank you.
This service is internal, and can not guarantee to survive at D10:
https://www.drupal.org/project/drupal/issues/2940481
Shortly, worried to be gone by D10 or so.
The best we can do is perhaps like this:
https://git.drupalcode.org/project/slick/-/blob/8.x-2.x/slick.module#L85
This way all D8 - D10 will be happy :)
Comment #8
mably commentedCould be a solution, yep +1
Comment #9
mably commentedTried to create a MR, first time for me, not sure it was done as it is supposed to be done ;)
Comment #11
gausarts commentedHm, not sure, either. I am new to web based PR :)
But normally merged happens only if committed, or selected below.
Untested against Upgrade Status module for D10, but perhaps something like this:
Feel free to correct the above in case I missed anything, or update your patch. Thanks.
Comment #12
mably commentedMy MR have been updated according to your suggestions above.
Code looks ok to me. At least it seems to be working fine on my D8 and D9 instances ;)
Comment #14
gausarts commentedWe'll release a hot fix shortly.
Committed. Thank you for contribution and keeping cool on critical matters :)
Much appreciated.
Comment #15
mably commentedYou're welcome :)