On line 17 of sites.admin.inc , you hardcoded the link: 

$output .= '<a href="/admin/build/sites/add">Add a new site</a>';

It should be

$output .= l(t('Add a new site'),'admin/build/sites/add');
CommentFileSizeAuthor
#4 cleanup.patch13.92 KBnquocbao
#3 clean.patch8.24 KBnquocbao
#2 clean.patch8.06 KBnquocbao

Comments

nquocbao’s picture

nquocbao commented

Man, there are huge of invalid links everywhere

nquocbao’s picture

nquocbao commented
Title: Admin link is invalid » Code cleanup
Assigned: Unassigned » nquocbao
StatusFileSize
new clean.patch8.06 KB

Beside the invalid admin link, bad implementation, other things work fine. So I spend sometime to clean up and add some more feature, such as allow user to delete the sites. The application is also lack of permission definition, I will add to the site later.

Check the patch.

nquocbao’s picture

nquocbao commented
StatusFileSize
new clean.patch8.24 KB

Ignore the above patch, there's a problem with PURL hooks.

nquocbao’s picture

nquocbao commented
StatusFileSize
new cleanup.patch13.92 KB

Here is more improvement:

If you enable this module, all created nodes can not be accessed until you select published sites, it's not very convenient when you want all node to be displayed on all sites by default. I also improve the views handle to give the option for you to choose to included unattached nodes or not.

Check the patch.

brynbellomy’s picture

brynbellomy commented

Committed! http://drupal.org/cvs?commit=348764 Thanks so much for your help. The code looks a lot better now. I've been absurdly busy at work and have not had a chance to mess with this module very frequently. If you're interested in doing more work on it, I'm happy to have you as a co-maintainer! Just message me in my contact form / email.

brynbellomy’s picture

brynbellomy commented
Status: Active » Reviewed & tested by the community
nquocbao’s picture

nquocbao commented

There is a problem with site access hook. I will up another patch later in this week.

nquocbao’s picture

nquocbao commented
Status: Reviewed & tested by the community » Active
nquocbao’s picture

nquocbao commented

Ah ha, I think you fix it already. Let close it for now

nquocbao’s picture

nquocbao commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.