CommentFileSizeAuthor
#4 simplesamlphp_auth-require-new-version-3050273-3.patch6.99 KBberdir
#2 simplesamlphp_auth-require-new-version-3050273-2.patch6.95 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Fix unit test fails » Require SimpleSAMLphp ^1.17.2 and use namespaced class names
Status: Active » Needs review
StatusFileSize
new simplesamlphp_auth-require-new-version-3050273-2.patch6.95 KB

So apparently the reason for the test fail is that we use the old non-namespaced configuration class which tries to log a warning.

Avoiding that by using the correct class, also relying on the new argument to pass in the configuration to Simple.

Berdir credited Mac_Weber.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new simplesamlphp_auth-require-new-version-3050273-3.patch6.99 KB

Strange, now suddenly externalauth is missing. Merging in the patch from #3041553: Missing drupal/externalauth dependency

oknate’s picture

oknate
Location Greater New York City Area
commented

I'm testing out this patch, so far, so good. +1 RTBC. I'll report any issues I see.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs review » Reviewed & tested by the community
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing.

  • Berdir committed 7fc7175 on 8.x-3.x 
    Issue #3050273 by Berdir, oknate, Mac_Weber: Require SimpleSAMLphp ^1.17...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.