Problem/Motivation

If a theme doesn't have a region named 'left' then a watchdog error will appear whenever saving the block config page because the module has the region specified as 'left' and status as '1'.

The message is: "The block simpleSAMLphp authentication was assigned to the invalid region left and has been disabled."

Proposed resolution

Don't set the region and status. Include the step to enable it (if needed) in the installation instructions. A more difficult one would be to detect the region and only set it if it exists.

CommentFileSizeAuthor
#2 simplesamlphp_auth-block-1797970-2.patch508 bytesbrad.bulger

Comments

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 6.x-2.7 » 6.x-3.x-dev

This doesn't exist in the D7 version, so nothing needs to be done there first.

brad.bulger’s picture

brad.bulger commented
Status: Active » Needs review
StatusFileSize
new simplesamlphp_auth-block-1797970-2.patch508 bytes

Patch sets the default block state to disabled in no region.

snufkin’s picture

snufkin commented
Issue summary: View changes
Status: Needs review » Fixed

Committed, thanks for the fix!

  • snufkin committed dea9d1f on 6.x-3.x authored by brad.bulger 
    Issue #1797970: removing hardcoded theme region by brad.bulger.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.