hello,

I installed the module, but it does not work.

I have my banner that appears anywhere in my page but not in overlay.

thank you

Jonathan

Comments

JonathanATC’s picture

JonathanATC commented
Title: Le module ne fonctionne pas » The module doesn't work
Issue summary: View changes
daften’s picture

daften commented

I have the same thing, but only for image type ads

liquidcms’s picture

liquidcms commented
Priority: Critical » Normal
daften’s picture

daften commented
Priority: Normal » Critical

Changing the priority without explanation is not done IMO, especially if the module just doesn't work properly in some use cases.

pmusaraj’s picture

pmusaraj commented
Priority: Critical » Major

Yes, you are correct, daften, the image ads do not work, and this is a major issue. I will look for a solution over the next little while. (Patches are welcome!)

Resetting priority to major, as a compromise.

pmusaraj’s picture

pmusaraj commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Active » Needs review

This issue is now fixed in the -dev branch.

daften’s picture

daften commented

That was quick, thanks. I'll check as soon as I find the time :)

liquidcms’s picture

liquidcms commented

@daften: fyi... Critical issues are typically reserved for issue which cause your site to fail. The fact that img ads don't work is hardly critical (not even major).

daften’s picture

daften commented
Category: Bug report » Task

Thanks both.
Tested it quickly, and it seems to work, but the overlay ad is not shown in an overlay for me.

liquidcms’s picture

liquidcms commented

and it seems to work, but the overlay ad is not shown in an overlay

what is working then? any screenshots of output or config?

daften’s picture

daften commented

It just shows the figure on the page, not in an overlay.