Problem/Motivation

Code should be clean and follow coding standards.

Steps to reproduce

When testing code with PHPStan following issues has been reported:

------ ----------------------------------------------------------------------- 
  Line   .../simple_sitemap_extensions/src/Plugin/simple_sitemap/UrlGene  
         rator/ExtendedEntityUrlGenerator.php                                   
 ------ ----------------------------------------------------------------------- 
  168    \Drupal calls should be avoided in classes, use dependency injection   
         instead                                                                
  245    Call to deprecated function file_create_url():                         
         in drupal:9.3.0 and is removed from drupal:10.0.0.                     
           Use the appropriate method on                                        
         \Drupal\Core\File\FileUrlGeneratorInterface                            
           instead.                                                             
 ------ ----------------------------------------------------------------------- 

Proposed resolution

Code should be fixed.
Work has been started already at:
https://github.com/drunomics/simple-sitemap-extensions/pull/11/files

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

golubovicm created an issue. See original summary.

useernamee’s picture

Status: Active » Reviewed & tested by the community

Checked PR. Code looks good.

  • useernamee committed b32acef on 1.0.x authored by golubovicm
    Issue #3299722 by golubovicm, useernamee: PHPStan reports 2 static code...
useernamee’s picture

Status: Reviewed & tested by the community » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.