The module doesn't seem to handle a 404 result? Maybe it's just my configuration, but the dialog just hangs, with the spinner going. I've manually checked the url and get a standard Drupal 404 page. Also checked the headers, nothing special there:

HTTP/1.1 404 Not Found
Server: nginx/1.4.6 (Ubuntu)
Date: Thu, 13 Nov 2014 11:36:11 GMT
Content-Type: text/html; charset=utf-8
Connection: keep-alive
X-Powered-By: PHP/5.5.9-1ubuntu4.5
X-Drupal-Cache: MISS
Expires: Sun, 19 Nov 1978 05:00:00 GMT
Last-Modified: Thu, 13 Nov 2014 11:36:10 GMT
Cache-Control: no-cache, must-revalidate, post-check=0, pre-check=0
ETag: "1415878570"
Content-Language: en
X-Generator: Drupal 7 (http://drupal.org)

Any ideas?

Comments

andy inman’s picture

andy inman commented
Title: Doesn't seem handle a 404 elegantly » Doesn't seem to handle a 404 elegantly
drclaw’s picture

drclaw commented
Status: Active » Fixed

Good point! I pushed a fix to the dev branch. Basically just drops a bit of feedback into the dialog (and removes the loader).

Thanks!

andy inman’s picture

andy inman commented

That's good service :) This module deserves more attention from the masses I think, lives up to its name nicely. One suggestion, off-topic here but probably not worth raising a separate issue for: why only a modal dialog? I tried overriding the jQuery settings to make it open non-modal, and that seems to work absolutely fine, i.e. the page behind the dialog stays live. So maybe add an option for modal or not? (sorry if that's already there and I've not noticed):

EDIT
Ignore that last part! Of course you can do it already by setting the jQuery options in the link itself:
el="{option-name1}:{value1};{option-name2}:{value2};"
right?

drclaw’s picture

drclaw commented

Hi,

Yeah, the modal setting is just a default really, it should be able to be overridden either on a link-by-link basis, or you can add it to the defaults on the settings page (admin/config/content/simple-dialog).

Glad you're finding the module useful! =)

drclaw

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.