The popup dialog will not function if an html link does not contain a title attribute. If no title attribute is specified, the popup should leave the title area blank, but still display the top bar with the X on it, like it does when you enter only a space for the title.

In my case, the title is already displayed within the popup content, so there is no need to have an additional title on the top of the popup window.

CommentFileSizeAuthor
#1 Missing_Title_Dialog_Fails-1960620-1.patch666 bytesaadityawalawalkar
#1 Missing_Title_Dialog_Fails_Default_Title-1960620-1.patch1.84 KBaadityawalawalkar

Comments

aadityawalawalkar’s picture

aadityawalawalkar commented
Status: Active » Needs review
StatusFileSize
new Missing_Title_Dialog_Fails_Default_Title-1960620-1.patch1.84 KB
new Missing_Title_Dialog_Fails-1960620-1.patch666 bytes

Please find the patch (Missing_Title_Dialog_Fails-1960620-1.patch) that works as you wanted.
Also find the patch (Missing_Title_Dialog_Fails_Default_Title-1960620-1.patch) that allows to define a default title for simple dialog which will be used in absence of "title" attribute in simple dialog link.
If default title attribute is left blank then simple dialog link's text will be used as simple dialog title.

drclaw’s picture

drclaw commented
Status: Needs review » Fixed

Hm... You know I was against this for some reason a while ago but I can't remember why now... Anyway, I like your second patch idea. I've applied it and pushed a new release. Thanks!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.