Hi guys!

We created Composer.Json file for Shell project.

The patch it's in attachment.

Good work.

Regards

Comments

renatog created an issue. See original summary.

mondrake’s picture

Status: Needs review » Needs work

Thanks. Since the module does not have dependencies, this is not needed, because the packaging process on d.o. provides the information for Composer from .info.yml files anyway, even with no composer.json.

If you runcomposer require drupal/shell on alpha1 you already get this on the composer.lock:

        {
            "name": "drupal/shell",
            "version": "1.0.0-alpha1",
            "source": {
                "type": "git",
                "url": "https://git.drupal.org/project/shell",
                "reference": "8.x-1.0-alpha1"
            },
            "dist": {
                "type": "zip",
                "url": "https://ftp.drupal.org/files/projects/shell-8.x-1.0-alpha1.zip",
                "reference": null,
                "shasum": "d4be79ea94bacc7ef281c20164624dc16ddb8e34"
            },
            "require": {
                "drupal/core": "~8.0"
            },
            "type": "drupal-module",
            "extra": {
                "branch-alias": {
                    "dev-1.x": "1.x-dev"
                },
                "drupal": {
                    "version": "8.x-1.0-alpha1",
                    "datestamp": "1487604487"
                }
            },
            "notification-url": "https://packages.drupal.org/8/downloads",
            "license": [
                "GPL-2.0+"
            ],
            "authors": [
                {
                    "name": "mondrake",
                    "homepage": "https://www.drupal.org/user/1307444"
                },
                {
                    "name": "richardp",
                    "homepage": "https://www.drupal.org/user/728184"
                }
            ],
            "description": "Web-based emulated shell access for your Drupal server.",
            "homepage": "https://www.drupal.org/project/shell",
            "support": {
                "source": "http://cgit.drupalcode.org/shell"
            }
        },

Rather, it would be useful to have a very stripped down version of the original patch with just name, description and type entries, plus adding a suggest entry for the drupal/admin_toolbar module, that allows a very simple access to Shell via the dropdown menu. See https://getcomposer.org/doc/04-schema.md#suggest.

This would pop up the recommendation to install admin_toolbar after loading of Shell, if it is not installed already.

renatog’s picture

Status: Needs work » Needs review
StatusFileSize
new982 bytes

Hi @mondrake how are you?

You are right.

In attachment the new patch.

Good work @mondrake.

Regards

renatog’s picture

StatusFileSize
new953 bytes
krina.addweb’s picture

Status: Needs review » Reviewed & tested by the community

@renatog,Thanks for the patch file it works well.

renatog’s picture

I thank you @krinaaddweb.

Regards.

mondrake’s picture

Thanks all. Will commit the following:

{
    "name": "drupal/shell",
    "description": "Web-based emulated shell access for your Drupal server.",
    "type": "drupal-module",
    "suggest": {
        "drupal/admin_toolbar": "Provides a drop-down menu interface to the core Drupal Toolbar. Allows a very simple access to Shell via the dropdown menu."
    }
}

  • mondrake committed 173631f on 8.x-1.x authored by renatog
    Issue #2854224 by renatog, mondrake, krina.addweb: Composer.Json for...
mondrake’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

renatog’s picture

Perfect @mondrake.

Thank you very much!

Hugs.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.