This won't take care of all the issues mentioned at http://ventral.org/pareview/httpgitdrupalorgprojectsessioncachegit-7x-1x, but it's a good start. Some of the issues mentioned there don't apply.

CommentFileSizeAuthor
#1 2035299-ventral-code-style-1.patch11.38 KBkscheirer

Comments

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Active » Needs review
StatusFileSize
new 2035299-ventral-code-style-1.patch11.38 KB

Does not contain any actual code changes, aside from moving session_cache_file_requirements() to session_cache_file.install.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks Karl!
Hope to attend to this soon.
Rik

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: kscheirer » rdeboer
Status: Needs review » Fixed

Phew!
I took it a step further and made sure there are zero errors and warnings.
Also set the default branch on the project page to 7.x-1.x and removed the master branch as required by ventral.org
Rik

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.