The reject is:
--- 503,526 ----
'line' => $method_info->getStartLine(),
'function' => $class . '->' . $method . '()',
);
+
+ // Run test in each browser.
+ foreach ($info['browsers'] as $browser) {
+ $this->browser = $browser;
+
+ $completion_check_id = DrupalTestCase::insertAssert($this->testId, $class, FALSE, t('The test did not complete due to a fatal error.'), 'Completion check', $caller);
+ try {
+ $this->setUp();
+ $this->$method();
+ // Finish up.
+ }
+ catch (Exception $e) {
+ $this->exceptionHandler($e);
+ }
+ $this->tearDown();
+ // Remove the completion check record.
+ DrupalTestCase::deleteAssert($completion_check_id);
}
}
}
This hunk fails with both 7.12 and the latest dev of Drupal.
And, thanks for this module, it's exactly what I was looking for.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1553258-4-update-core-patch-for-latest-drupal.patch | 3.76 KB | ygerasimov |
| #2 | 1553258-2-update-core-patch-for-latest-drupal.patch | 3.82 KB | alberto56 |
Comments
Comment #1
alberto56 commentedBy the way, the module still works with Firefox.
Comment #2
alberto56 commentedSo here is a patch that can be applied to the selenium module. It updates the patch included in the selenium module, called D7-core-selenium.patch, so that that patch can apply cleanly to the latest dev version of Drupal 7.
Comment #3
alberto56 commentedComment #4
ygerasimov commentedVery important point is missing in patch #2 that we expect $this->setUp() to throw exception. I have added try - catch logic. See attached patch.
Comment #5
alberto56 commentedNote that this patch is not necessary with the 7.x-3.x branch, only 7.x-2.x